#10737: Interactive legend for TOC layers [Vector Layer part] #10798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r part] Description: - handle adding checkbox in layer settings in TOC for enabling/disabling interactive legend for vector layer - handle the same behaviour in WFS/WMS of hovering effect on the legend items if classified on TOC and select effect - Add interactivity to the Vector Legend for the vector layer in cesium, openalayers and leaflet - add unit tests
allyoucanmap
requested changes
Feb 13, 2025
|
@mahmoudadel54 please solve also the conflicts with master branch |
allyoucanmap
requested changes
Feb 20, 2025
tdipisa
reviewed
Feb 21, 2025
There was a problem hiding this comment.
@mahmoudadel54 I see failing checks on unit tests here. Please check asap.
|
@tdipisa @mahmoudadel54 already fixed |
allyoucanmap
approved these changes
Feb 21, 2025
|
@ElenaGallo please test this enhancement on dev, thanks |
Ok, thank you. I'm sorry for the overlap @allyoucanmap |
mahmoudadel54
added a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handled adding the interactivity to the Vector Legend for the vector layer in cesium, openalayers and leaflet. It includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10737
What is the current behavior?
#10737
What is the new behavior?
Now user can interact with the vector legend for vector layers if it is enabled by user from TOC.
recording.14.mp4
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
To test it, you should add
"miscSettings": { "experimentalInteractiveLegend": true},to localConfigTo test functionality for leaflet maps, you should change this:
MapStore2/web/client/utils/MapTypeUtils.js
Line 30 in 490d96d
to
desktop: MapLibraries.LEAFLET