#10424: The measure tool is not opened properly if Measure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions #10428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions Description: - fix UI issue in measure
1 task
allyoucanmap
requested changes
Jun 17, 2024
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions Description: - resolve review comments [change the added class name + handle all mentioned cases] - add unit test
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions Description: - add unit test
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions Description: -change the added class name to a more generic name
allyoucanmap
approved these changes
Jun 21, 2024
|
@ElenaGallo please test on dev and let us know when backport on 2024.01.xx, thanks |
|
Test passed @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jun 21, 2024
…sure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions (geosolutions-it#10428)
Backport is done ---> #10440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, fix UI issue for the measure tool is done. Due to this fix, the measure tool is opened properly as expected if Measure plugin has 'showCoordinateEditor' with true into cfg.defaultOptions.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10424
What is the current behavior?
#10424
What is the new behavior?
The measure tool UI is shown as expected when it is open for both 2D and 3D maps.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information