Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to save resource with thumbnail not allowed #4758

Closed
1 task done
ElenaGallo opened this issue Jan 21, 2020 · 3 comments
Closed
1 task done

Ability to save resource with thumbnail not allowed #4758

ElenaGallo opened this issue Jan 21, 2020 · 3 comments

Comments

@ElenaGallo
Copy link
Contributor

ElenaGallo commented Jan 21, 2020

Description

When the thumbnail with size (over 500Kb) or extensions (.gif) not allowed is added on save window, the warning message is displayed but the resource is saved anyway.
issue56

How to reproduce

  • click on new map
  • click on save
  • change the thumbnail with over 500Kb or a .gif
  • click on save
  • go back to the homepage
  • search the map

Expected Result

The map cannot be saved if the thumbnail is not supported and the relative warning message appears

Current Result

The map is saved anyway and it is present on the homepage without any thumbnail

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@tdipisa
Copy link
Member

tdipisa commented Aug 6, 2020

An updated status for this issue is described below.

Description

If you save a map changing a thumbnail with a size over than the max allowed one (500kb) the map is saved anyway with a wrong thumbnail state.

test_map_save_thumb

How to reproduce

  • Follow the steps in the animated gif (the map used for this is available here)

Expected Result

The same behavior of changing the thumbnail in home page should be respected: the map is saved but the thumbnail is empty and looks like the following:

image

Current Result

The thumbnail is in a wrong state, look at the animated gif. After saving the map the first time and reopening the map properties, the thumbnail is not changed in the UI. But, If I refresh the map and then I reopen the map properties the thumbnail is in a wrong state (it looks gray). If now I go back in the home page and I search for the map the thumbnail is in the same wrong state.

@ElenaGallo
Copy link
Contributor Author

Now after a thumbnail of wrong size (over the 500 kb) is edded there are two different behaviors:

  1. for the map, after saving the thumbnail with an oversize image, from the homepage, the thumbnail is empty
    thmb from home2

  2. for dashboard, story and map (only from the map viewer) saving the thumbnail with a oversize image the thumbnail remains the old one
    thmb from viewer2

@tdipisa which of the two is the one to keep?

@tdipisa
Copy link
Member

tdipisa commented Sep 2, 2020

@ElenaGallo in my opinion it should be the second one. @offtherailz what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants