Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation do not work without setting initial state #3852

Closed
offtherailz opened this issue Jun 20, 2019 · 1 comment
Closed

Annotation do not work without setting initial state #3852

offtherailz opened this issue Jun 20, 2019 · 1 comment

Comments

@offtherailz
Copy link
Member

Description

Creating a new project and adding the plugin, I can not create the annotation(it fails when add geometry).
To make annotations work, i need to set up the initial state.

 "annotations": {
        "config": {
          "multiGeometry": true,
          "validationErrors": {}
        },
        "format": "aeronautical",
        "defaultTextAnnotation": "New"
      },

In case of Bug (otherwise remove this paragraph)

Browser Affected
(use this site: https://www.whatsmybrowser.org/ for non expert users)
any

Steps to reproduce

  • localConfig.json should contain "Annotations" plugin, with no annotations initialState set.
  • Try to create a new annotation (annotations from burger menu -> click on "+")
  • Add a new geometry, of type marker (pencil+ button-> marker)
  • click on map

Expected Result

  • I see the marker on map

Current Result

  • nothing happens
  • a row appears in the panel

Other useful information (optional):

@tdipisa tdipisa added this to the 2019.02.01 milestone Jun 20, 2019
kasongoyo added a commit to kasongoyo/MapStore2 that referenced this issue Aug 8, 2019
…al state

It turned out the annotation plugin cannot draw on the map when
the default configuration is not provided. This commit fix and allow
annotation to work well without default config.
@offtherailz offtherailz reopened this Aug 9, 2019
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this issue Aug 9, 2019
@francoxyz francoxyz self-assigned this Sep 9, 2019
@francoxyz francoxyz removed the Accepted label Sep 9, 2019
@francoxyz francoxyz removed their assignment Sep 9, 2019
@francoxyz francoxyz reopened this Sep 9, 2019
@francoxyz francoxyz self-assigned this Sep 11, 2019
@MV88
Copy link
Contributor

MV88 commented Sep 11, 2019

alreday backported to 2019.02.xx with this pr #4084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants