Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUBMODULE UPDATES] GCHP missing value handling fixes #258

Closed
2 tasks done
lizziel opened this issue Oct 18, 2022 · 1 comment
Closed
2 tasks done

[SUBMODULE UPDATES] GCHP missing value handling fixes #258

lizziel opened this issue Oct 18, 2022 · 1 comment
Assignees
@lizziel
Labels
category: Bug Something isn't working
Milestone
14.1.0

Comments

@lizziel
Copy link
Contributor

lizziel commented Oct 18, 2022 •
edited by msulprizio
Loading

Brief Description

Code updates to identify missing values from _FillValue attribute in input files and fix usage of missing value handling for scaling/masking in HEMCO when using models that use MAPL.

Related Issues

Incorrect missing value handling was previously reported in a couple GCHP issues:
#183
#251

The reports led to bug reports and fixes in MAPL:
GEOS-ESM/MAPL#1294
GEOS-ESM/MAPL#1489
GEOS-ESM/MAPL#1506
GEOS-ESM/MAPL#1305

The HEMCO issue is reported in:
geoschem/HEMCO#172

Submodule Pull Requests
@lizziel lizziel added the category: Bug Something isn't working label Oct 18, 2022
@lizziel lizziel added this to the 14.1.0 milestone Oct 18, 2022
@lizziel lizziel self-assigned this Oct 18, 2022
@lizziel lizziel mentioned this issue Oct 18, 2022
Closed
@lizziel lizziel changed the title [BUG/ISSUE] Superproject instructions for GCHP missing value handling fixes Superproject instructions for GCHP missing value handling fixes Oct 18, 2022
@lizziel lizziel mentioned this issue Oct 24, 2022
Closed
@lizziel lizziel changed the title Superproject instructions for GCHP missing value handling fixes [INSTRUCTIONS FOR SUPERPROJECT] GCHP missing value handling fixes Nov 4, 2022
This was referenced Nov 4, 2022
Merged
Merged
Closed
@lizziel lizziel changed the title [INSTRUCTIONS FOR SUPERPROJECT] GCHP missing value handling fixes [SUBMODULE UPDATES] GCHP missing value handling fixes Nov 7, 2022
@msulprizio
Copy link
Contributor

The two PRs linked above have now been merged into dev/14.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizziel lizziel

Labels
category: Bug Something isn't working
Projects
None yet
Milestone
14.1.0
Development

No branches or pull requests
2 participants
@lizziel @msulprizio