Expand allowed _FillValue type and error handling in FileMetadataUtilities.F90 #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
reviewed
May 16, 2022
mathomp4
reviewed
May 16, 2022
|
@lizziel Looks good. I'm not sure why GEOSadas test failed here. I'm going to re-run it to see if it was a transient issue or something fundamental. |
Nope. It's fundamental. I'll need to fix this and get a fix on |
|
@lizziel Okay. Can you update your end to the latest develop. I've fixed the CI issue now. |
4 tasks
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
This update prevents run fail when retrieving _FillValue from import files containing double precision data. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
29ee301 to
e484e71
Compare
|
I rebased on the latest develop. Hopefully this time all will pass. |
|
All looks good. I'll run a GEOSgcm run just to make sure it's happy (I can't see why it wouldn't). |
mathomp4
approved these changes
May 17, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update expands error handling in FileMetadataUtilities to print filename in all calls to
_ASSERTand_FAIL. Fail messages about unsupported attribute type now specify the unique type constraint per function. For single precision attribute retrieval there is now handling for double precision input.Related Issue
Closes #1489
Motivation and Context
This update prevents run fail when retrieving
_FillValuefrom import files containing double precision data used GCHP. It also expands the error handling so that failure on reading import attributes always results in a unique message with the filename, making it easier to find and fix the problem.How Has This Been Tested?
Types of changes
Checklist:
NOTE: I tested this update successfully with GCHP using MAPL 2.18.3. It was not a straightforward cherry-pick due to the addition of _FAIL but I will fix any build issues if they show up in the automatic build test.