Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsqlite3-sys to allow 0.31 as well #218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

weiznich
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to the project's change log file if knowledge of this change could be valuable to users.
    • Usually called CHANGES.md or CHANGELOG.md
    • Prefix changelog entries for breaking changes with "BREAKING: "

@weiznich
Copy link
Contributor Author

weiznich commented Jan 20, 2025

Seems like CI fails due to the new libsqlite3 version requiring a newer rust version. What would need to be done to bump that version?

@lnicola
Copy link
Member

lnicola commented Jan 20, 2025

We've just bumped the MSRV, I'm all for doing it again.

@urschrei
Copy link
Member

What would our new MSRV need to be? geo is "officially" current - 2 right?

@lnicola
Copy link
Member

lnicola commented Jan 20, 2025

stable - 3, or currently 1.81. I see #[expect] in the CI logs, which was stabilized in 1.81.

EDIT: might actually be 1.82 for unsafe extern.

@weiznich
Copy link
Contributor Author

weiznich commented Jan 20, 2025

Technically this wouldn't need a msrv change, as proj still would support the older libsqlite3-sys versions, so anyone that depends on older rust versions could just use an older libsqlite3-sys version. The question is more how do you want to express that in your CI setup. For diesel I just do the minimal rust version build with cargo minimal-versions to enforce that it uses the minimal possible dependency versions that are most likely to build on older rust versions.

@weiznich
Copy link
Contributor Author

It seems like it's currently impossible for me to work on the CI as it's not possible to run jobs here without approval and I also cannot run jobs on a fork as its impossible to pull images there

@urschrei
Copy link
Member

Your PR runs here should no longer require approval. We're aware of the image-pull annoyance, I just haven't had time to figure out how to make the images public so they work in forks.

@urschrei
Copy link
Member

@weiznich your fork should now be able to run its Actions. lmk if it can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants