attempt to better document Simplify traits epsilon parameter
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The triangle explanation (which is correct!) only applies to the Visvalingam-Whyatt algorithm. The RDP algorithm (which underlies Simplify) is distance-based… |
|
Thank you! Please take another look @urschrei |
michaelkirk
commented
Feb 20, 2024
| @@ -192,7 +198,13 @@ pub trait Simplify<T, Epsilon = T> { | |||
| /// This operation uses the [Ramer–Douglas–Peucker algorithm](https://en.wikipedia.org/wiki/Ramer–Douglas–Peucker_algorithm) | |||
| /// and does not guarantee that the returned geometry is valid. | |||
| /// | |||
| /// An epsilon less than or equal to zero will return an unaltered version of the geometry. | |||
There was a problem hiding this comment.
A related question is can we alter our algorithm such that epsilon == 0 will remove collinear points, but nothing else?
There was a problem hiding this comment.
Maybe with distance and area calculations it's not feasible to have epsilon == 0 from a robustness perspective...
There was a problem hiding this comment.
Hmm I don't know that either algorithm can be made to work precisely like that. I can have a look at "the literature".
urschrei
approved these changes
Feb 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.I'm actually not sure if this is what the parameter really means, but it's my best guess at this point. Is anyone more familiar willing to clarify?