Add Milvus integration for vector create and search #1269
Conversation
There was a problem hiding this comment.
👋 Hello @RichardZhangRZ, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/evamasterbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
|
Hi Richard, thanks for the contribution! What is the status of the pull request? |
|
Hi @RichardZhangRZ , is this PR ready? Thanks! |
There are still ongoing conversations, but other than that, the PR should be ready |
|
We need to address some merging conflicts. |
ec8146a to
410361b
Compare
|
The merge does not look correct. I will give it a try. |
.circleci/config.yml
Outdated
| else | ||
| pip install ".[dev,pinecone,chromadb]" # ray < 2.5.0 does not work with python 3.11 ray-project/ray#33864 | ||
| pip install ".[dev,pinecone,chromadb,milvus]" # ray < 2.5.0 does not work with python 3.11 ray-project/ray#33864 |
There was a problem hiding this comment.
Remove milvus since we are not running any test.
| * `MILVUS_DB_NAME` is the name of the database to be used. This will default to the `default` database if not provided. | ||
| * `MILVUS_TOKEN` is the authorization token for the Milvus instance. | ||
|
|
||
| The above values can either be set in the evadb.yml config file, or in the os environment fields "MILVUS_URI", "MILVUS_USER", "MILVUS_PASSWORD", "MILVUS_DB_NAME", and "MILVUS_TOKEN" |
There was a problem hiding this comment.
Use SET command is the way to do it now. Example: SET MILVUS_URI = 'http://localhost:19530;'. We no longer have evadb.yml file. OS environment is not recommended, since it does not work in a client-server setup.
Integrated Milvus vector store into EvaDB. Added a
MilvusVectorStoreclass and Milvus type for query parsing and execution.Below are environment values for the use of the Milvus index:
MILVUS_URIis the URI of the Milvus instance (which would be http://localhost:19530 when running locally). This value is requiredMILVUS_USERis the name of the user for the Milvus instance.MILVUS_PASSWORDis the password of the user for the Milvus instance.MILVUS_DB_NAMEis the name of the database to be used. This will default to thedefaultdatabase if not provided.MILVUS_TOKENis the authorization token for the Milvus instance.