Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header-config-file #435

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Add header-config-file #435

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83daeff
feat: add header config file
f-necas Feb 6, 2025
8af7083
fix: update with @landryb suggestions
f-necas Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions default.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ headerUrl=/header/
# Default empty string
# georchestraStylesheet=http://my-domain-name/stylesheet.css

# Config file for the header webcomponent
# You can use this file to change the menu design, add new items, etc.
# Full configuration cna be found here: https://github.com/georchestra/header/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyop on can/cna

# Default empty string
# headerConfigFile=http://my-domain-name/public/config.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt we show that urls without the fqdn should be preferred, eg /public/config.json ? helps for dev/staging/prod urls


# Logo URL
# Used to set header's logo.
logoUrl=https://www.georchestra.org/public/georchestra-logo.svg
Expand Down