align geostore.properties to commit 9ba3bac9bea7dfd6d3c899ee93aeaf6a049f058a #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. Regarding the SQL files, their integration in the geOrchestra project is still pending, with the (ill-named) georchestra/georchestra#3058 |
the sigle sql file with mapstore name was merged short while ago: https://github.com/georchestra/mapstore2-georchestra/tree/master/database |
OK, but IMO it should also be added in https://github.com/georchestra/georchestra/tree/master/postgresql |
5 tasks
|
conflicts resolved, this can be merged @fvanderbiest |
9085b78 to
6c9d684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @fvanderbiest
since we updated the name of the pg schema from "geostore" to "mapstore" we need also to modify this file to make mapstore awayre of the correct schema.
Also the schema name change affects two files in georchestra/mapstore2-georchestra repository:
https://github.com/georchestra/mapstore2-georchestra/tree/master/database