-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MapStore config files #186
Add MapStore config files #186
Conversation
geostoreEntityManagerFactory.jpaPropertyMap[hibernate.default_schema]=geostore | ||
geostoreVendorAdapter.generateDdl=true | ||
geostoreVendorAdapter.showSql=false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we avoid the windows-style line endings ? ^M ;)
@fvanderbiest @landryb I should have fixed everything |
I launched the composition. I have this trace and 404 when going the
Do I need to do something. Is the latest image need some kind of special conf ? |
Why not adding a sample |
@Gnafu up, thanks :-) |
Sorry for the late reply, I didn't get the notifications. |
@RemiDesgrange can you please provide me the steps you did to reproduce the error? |
I think Remi just followed the steps from https://github.com/georchestra/docker/blob/master/README.md |
Yes François is right. I "just" Sorry for the late reply. |
@RemiDesgrange I updated the PR for the "docker" repo. (georchestra/docker#58) Can you please verify? Thank you |
So they can be customized by just editing them in the datadir
In addition, can you add a small README in the mapstore subfolder explaining what the json files are for ? Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it target docker, it should have consoleAppender
like here in log4j config file instead of fileAppender.
@RemiDesgrange consoleAppender is now the default |
@Gnafu what's the status of this PR ? i guess it should probably be updated wrt last changes in mapstore2-georchestra? And backported to 20.0.x too - cc @catmorales @jusabatier |
also i realized this PR targets docker-master, but there should also be one updating master & 20.0.x ? Lost in all those branches... |
Ideally yes, it should target master, but that's not a problem, we can take care of the cherry-pick and adapt to the non-docker use-case (regarding logging & security proxy config), unless @Gnafu takes care of it too. When this is done, a backport to the 20.0 and docker-20.0 branches would be a good idea indeed. |
Dear @landryb @RemiDesgrange and @fvanderbiest, I'm sorry for the late reply. As I already reported here we are resuming the work of @Gnafu since he is not available this period. Correct me if I'm wrong but, as far as I know and @Gnafu reported me some time ago, all is completed for this PR, we only need to check the problem reported by @RemiDesgrange in georchestra/docker#58 and then I think that also this PR can be merged (to consider also a syncup of MS config filed in datadir, see here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name in default postgres connection values
with "OpenStreetMap" offical name instead of "Open Street Map"
A new PR should be made to port these files to the master branch (in a no-docker context) |
and i would say a PR targetting master branch (and 20.x) was more important than one targetting docker-master.. @tdipisa please keep this one on your dashboards :) |
No, I meant in the current repo. To make it clearer:
Between the docker and non-docker setup, at least the log4j config files have to change ... |
No description provided.