Add hot-reload option to docker entrypoint #1880
Open
+40
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doublebyte1
approved these changes
Dec 17, 2024
totycro
approved these changes
Dec 18, 2024
docker/entrypoint.sh
Outdated
| --reload-extra-file ${PYGEOAPI_CONFIG} \ | ||
| pygeoapi.flask_app:APP | ||
|
|
||
| touch ${PYGEOAPI_CONFIG} |
There was a problem hiding this comment.
Are you sure this touch is actually executed?
As far as I understand it, exec gunicorn replaces the bash process with gunicorn and thus stops any further execution of the script, or is this somehow different here?
There was a problem hiding this comment.
pygeoapi_es | [2025-02-18 18:01:04 +0000] [19] [INFO] Worker exiting (pid: 19)
pygeoapi_es | [2025-02-18 18:01:04 +0000] [75] [INFO] Booting worker with pid: 75
pygeoapi_es | [2025-02-18 18:01:08 +0000] [51] [INFO] Worker reloading: /pygeoapi/local.config.yml modified
pygeoapi_es | [2025-02-18 18:01:08 +0000] [60] [INFO] Worker reloading: /pygeoapi/local.config.yml modified
pygeoapi_es | [2025-02-18 18:01:08 +0000] [60] [INFO] Worker exiting (pid: 60)
pygeoapi_es | [2025-02-18 18:01:09 +0000] [84] [INFO] Booting worker with pid: 84
apache-httpd | 172.20.0.1 - - [18/Feb/2025:18:01:05 +0000] "POST /admin/config/resources HTTP/1.1" 201 67
pygeoapi_es | [2025-02-18 18:01:13 +0000] [51] [INFO] Worker exiting (pid: 51)
pygeoapi_es | [2025-02-18 18:01:13 +0000] [92] [INFO] Booting worker with pid: 92
pygeoapi_es | [2025-02-18 18:01:16 +0000] [59] [INFO] Worker reloading: /pygeoapi/local.config.yml modified
pygeoapi_es | [2025-02-18 18:01:16 +0000] [59] [INFO] Worker exiting (pid: 59)
pygeoapi_es | [2025-02-18 18:01:16 +0000] [84] [INFO] Worker reloading: /pygeoapi/local.config.yml modified
pygeoapi_es | [2025-02-18 18:01:16 +0000] [84] [INFO] Worker exiting (pid: 84)
pygeoapi_es | [2025-02-18 18:01:16 +0000] [75] [INFO] Worker reloading: /pygeoapi/local.config.yml modified
pygeoapi_es | [2025-02-18 18:01:16 +0000] [101] [INFO] Booting worker with pid: 101
pygeoapi_es | [2025-02-18 18:01:17 +0000] [102] [INFO] Booting worker with pid: 102
There was a problem hiding this comment.
@doublebyte1 this comment has already been addressed in a recent commit, the touch command is removed now.
There was a problem hiding this comment.
This was a change I made after @doublebyte1 reviewed. All good
|
I have tested this and it seems to work. I think there are just some conflicts on the documentation that need to be resolved? |
Create WSGI_APP for gunicorn entrypoint with default value of `pygeoapi.flask_app:APP`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds hot reload option to docker entrypoint. Thereby fully enabling the function of the Admin API in the Docker deployment of pygeoapi
Related Issue / discussion
#1753
#1636
Additional information
This is not a complete implementation, but enough for someone to start developing a pygeoapi-ui of the base docker image.
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)