DOC: update pyogrio introduction #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: "vectorized" - that was originally added to distinguish it from Fiona, which one could describe as having a more iterative API: you loop over individual features in the Python API. Whereas in pyogrio, the looping happens in compiled code, so it presents results as arrays (vectors) of features. But it was a shorthand reference and not particularly clear, so it is fine for that to go away. |
brendan-ward
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Thanks @theroggy - this is looking better! A couple minor comments.
brendan-ward
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pyogrio introduction was slightly dated in some locations, so I started off with doing some minor updates.
However, I got a bit carried away with making small changes here and there... I also changed the order of some blocks of text, which doesn't help to see the exact changes applied :-(.
For the "vectorized", not sure why this term was used, but I don't think it is really relevant for what happens in pyogrio, or possibly I'm just wrong on that?
Anyway, if it's not an improvement, just say so, a PR is easy to delete again ;-) (or rather, to close without merging).