ENH: Add GeometryArray._from_sequence_of_strings #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be good to add a small test that reading from CSV with specifying the dtype works (essentially what you did in the issue). While we indeed don't need to test the details of what kind of strings work for |
|
Makes sense, added! |
|
@jorisvandenbossche believe this is ready, I think the test failure is unrelated |
|
Looks good to me! Can you also add a short line to the changelog? |
m-richards
approved these changes
Dec 30, 2023
jorisvandenbossche
approved these changes
Jan 3, 2024
|
@martinfleis done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3099.
Like
_from_sequenceright above, I minimally edited the abstract base function to give the desired behavior.@martinfleis think this warrants its own test since it's more or less an alias of
from_wkt...?