Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path for serverTime / sessionExpiry when GeoNetwork runs in / It creates these cookies per each path. #7446

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix path for serverTime / sessionExpiry when GeoNetwork runs in / It creates these cookies per each path. #7446

merged 1 commit into from
Oct 23, 2023

Conversation

josegar74
Copy link
Member

request.getContextPath() for servlets in the root context, returns an empty string instead of /. The browser doesn't receive the path, uses the request path for the cookie.

1VGVQC0aQbn6

Thanks @juanluisrp for reporting the issue.

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74
Fix path for serverTime / sessionExpiry when GeoNetwork runs in /. It…
814b3ad 
… creates these cookies per each path.

request.getContextPath() for servlets in the root context, returns an empty string instead of /. The browser doesn't receive the path, uses the request path for the cookie
@josegar74 josegar74 added this to the 4.4.1 milestone Oct 20, 2023
@josegar74 josegar74 requested a review from juanluisrp October 20, 2023 14:51
juanluisrp
juanluisrp approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@juanluisrp juanluisrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanluisrp juanluisrp merged commit 312c28f into geonetwork:main Oct 23, 2023
juanluisrp pushed a commit that referenced this pull request Oct 23, 2023
@josegar74 @juanluisrp
[BP] Fix cookies path when deployed on root "/" context (#7446)
e3dfa4a 
request.getContextPath() for servlets in the root context, returns an empty string instead of /.
The browser doesn't receive the path, uses the request path for the cookie
juanluisrp pushed a commit that referenced this pull request Oct 23, 2023
@josegar74 @juanluisrp
[BP] Fix cookies path when deployed on root "/" context (#7446)
1105846 
request.getContextPath() for servlets in the root context, returns an empty string instead of /.
The browser doesn't receive the path, uses the request path for the cookie
@juanluisrp
Copy link
Contributor

Merged and backported to 3.12.x and 4.2.x branches.

@juanluisrp juanluisrp deleted the sessiontimeoutcookies-path-rootapp branch October 23, 2023 10:44
@juanluisrp juanluisrp mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisrp juanluisrp juanluisrp approved these changes

Assignees
No one assigned
Labels
backport 3.12.x backport 4.2.x
Projects
None yet
Milestone
4.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@josegar74 @juanluisrp