Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema / Utility / Add copy script. #4946

Closed

Conversation

fxprunayre
Copy link
Member

While working, developers may want to have a quick update of the schema plugins.

Using this script with file watcher plugin in Intellij, update the plugins on file change.

image

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great, thanks.

@ianwallen
Copy link
Contributor

Looks good however I believe there should be more documentation in the script explaining it's usage. I don't believe a user who finds this script will have the nice documentation that was place in the PR description. It would be really great if you could past that screenshot in the script!!. Maybe a link to this PR should be in the script or maybe just a little bit documentation.

I do find that there are a couple scripts in the root which are difficult to understand the reason for there existence other then going thought the git logs and referencing the PR. It may be a good idea at some point to put them in a script folder and create an readme.md with documentation on the usage.

@jodygarnett
Copy link
Contributor

Can you please instead review proposa rather than adding more complexity and scripts?

https://github.com/geonetwork/core-geonetwork/wiki/Resolve-competing-web-module-war-definitions

@fxprunayre
Copy link
Member Author

fxprunayre commented Aug 19, 2020

too complex, closing.

BTW, devs can also trigger mvn to make the copy with the correct arguments
image
which takes a bit more time but works well too.

Sorry for sharing complexity. File watchers is a nice plugin I was not aware off.

@fxprunayre fxprunayre closed this Aug 19, 2020
@jodygarnett
Copy link
Contributor

jodygarnett commented Aug 21, 2020

BTW, devs can also trigger mvn to make the copy with the correct arguments

That is fun, consider adding to the https://github.com/geonetwork/core-geonetwork/blob/master/software_development/INTELLIJ.md documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants