Metadata file store / Encode file name for URL. #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegar74
reviewed
Mar 14, 2018
the issue is that right now, all those characters are allowed on windows, linux, ... and the URL created is wrong. Trying to upload a file with a character unsupported by the server filesystem is another problem. Which characters may cause problems ? |
|
Looks fine then. I need to check, but in some Ubuntu I got issues with some characters like |
fxprunayre
added a commit
to fxprunayre/core-geonetwork
that referenced
this pull request
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If attachement's file name contains characters that need to be encoded in URL, they are not for now
In the XML
Should be
Thinking of how to migrate existing records ... any suggestions welcomed.