Spatial search: Bbox filters #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove 'to do javadoc' refactor
…e... to handle right 'true' multipolygon and within operator, have to count matching polygons and to compare with effective parts count as oguyot showed, forbid call of geometries operating filter from minimap and provide translations for bbox filter (filter is overlaps_bbox when no definition embedded in request)
…ule.js for second one
|
@fgravin ? |
|
@fxprunayre @josegar74 no objection ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR comes with refactorings which helped to better take measure of geonetwork spatial indexing mechanisms.
The purpose of this PR is to propose two spatial filters operating on bbox rather than on geometries, in order to earn ram and cpu at runtime:
In my opinion, replacing Data Pair by POJO helps a lot:
https://github.com/geonetwork/core-geonetwork/pull/2555/files#diff-431f31b5144d54b586f8eabcdda4567aL415.
vs
https://github.com/geonetwork/core-geonetwork/pull/2555/files#diff-431f31b5144d54b586f8eabcdda4567aR559
In this case, for a true multipolygon and within filter POJO help counting and checking that all its parts are enclosed within query bounds.