Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO19139 / Add table view mode for contact #1647

Merged

Conversation

fxprunayre
Copy link
Member

This mode is applied in flat mode (ie. simple view) or when using an editor configuration with:

 <xsl xpath="/gmd:MD_Metadata/gmd:identificationInfo/*/gmd:pointOfContact"
         mode="iso19139-table-contact"/>

image

Advantages with template mode used in INSPIRE view is that it also support multilingual elements.

@josegar74 Could you review that and see if that also cover your needs on the swedish project ? thanks.

One future improvement would be to be able to configure a table from the config-editor section directly.

@josegar74
Copy link
Member

For my project is a bit different, we use the table just to display the elements and use popup dialogs to edit the values.

In any case, I think can be unified, extending your code in a later stage to allow the 2 editing modes, will take a look to this.

@fxprunayre, before merging the code, just to be clear: the contact editing is not changed by default, I mean the table mode is not used by default unless the user changes the config-editor.xml, correct?

@fxprunayre
Copy link
Member Author

default unless the user changes the config-editor.xml, correct?

Yes.

to allow the 2 editing modes

An option could be that the table view mode display a subset of fields and a popup mode basically display the advanced mode to allow editing all fields ?

@josegar74
Copy link
Member

An option could be that the table view mode display a subset of fields and a popup mode basically display the advanced mode to allow editing all fields ?

That could be an option, for the project I'm managing the dialogs are created manually with the fields to edit, but this should be improved. An option could be to use the template defined in config-editor.xml if exists otherwise use the advanced mode as you indicate.

For the time being, going to merge the pull request.

@josegar74 josegar74 merged commit 4c302b7 into geonetwork:develop Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants