Add schema.org tags in xsl formatter. #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacer for #1511
It does not create a new formatter but instead improve the existing XSL formatter based on editor-config.xsl for rendering a record. The formatter now provide schema.org tags.
eg.
http://localhost:8080/geonetwork/srv/api/records/da165110-88fd-11da-a88f-000d939bc5d8/formatters/xsl-view
http://localhost:8080/geonetwork/srv/api/records/da165110-88fd-11da-a88f-000d939bc5d8/formatters/xsl-view?root=div&view=advanced
The formatter is also bind to the nojs XSL template for header and footer to make layout more similar in all HTML pages.
@pvgenuchten , if you could have a look before merging that would be good, I tried to pick up all the changes made in #1511 but would be good to have a double check ? I also added some FIXME to be addressed later. It would be good if someone can improve the CSS of the XSL formatter so we provide a good default - like the one you show me in Bolsena with a map on top (@MichelGabriel maybe ?)