Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configure locale files in views #1533

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

josegar74
Copy link
Member

Enhancement of GnLocale to allow load translations defined in custom views while also loading the default GeoNetwork translations.

Previously, the only way to add custom translations in a view was to modify the locale files from GeoNetwork, not optimal.

With this change, you can define in your view a snippet like this with the path and name of the locale name to load:

module.config(['$LOCALES', function($LOCALES) {
  $LOCALES.push('../../catalog/views/sdi/locales/|search');
}]);

Maybe there's a better way to do this, but this works and it's quite simple to setup.

@fxprunayre , @fgravin If you can review and merge it if looks fine would be great. Thanks.

@josegar74 josegar74 added this to the 3.1.0 milestone Apr 20, 2016
@Delawen Delawen self-assigned this May 6, 2016
@josegar74
Copy link
Member Author

@fxprunayre , @fgravin any chance to review this?

@fxprunayre fxprunayre merged commit b769550 into geonetwork:develop Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants