introduce header/footer for no-js ui #1492
Conversation
and link each search result to /metadata/{uuid} (urlrewrite can forward this to some formatter for the metadata)
| @@ -76,7 +76,7 @@ | |||
| else if ($service = 'catalog.viewer') then 'gn_viewer' | |||
| else if ($service = 'catalog.search') then 'gn_search' | |||
| else if ($service = 'md.viewer') then 'gn_formatter_viewer' | |||
| else 'gn'"/> | |||
| else 'gn_search'"/> | |||
There was a problem hiding this comment.
I don't really understand this change. Is not going to affect the standard UI?
There was a problem hiding this comment.
it seemed a bug, because if i leave this on gn, i get a css-not-found-error, but i'll have a look
There was a problem hiding this comment.
In some project, we have css classes and behavior matched on the .gn selector.
This will break this.
Could you keep the gn class at least ?
There was a problem hiding this comment.
ok @fgravin, I'll check how to improve it
|
Is there a real usage for this? I'm not sure nowadays a UI without any javascript is very functional. I think would be better to work towards making the AngularJS really accesible using aria attributes, etc. |
|
About the usecase, yes it makes quite some sense, accessibility is actually not the main reason. The current angular website for example is not crawlable by search engines. For sure there are other ways to make it crawlable, but the nojs interface is a development which is already there, and needs minimal tweaking to facilitate it. So some of the benefits:
|
|
Travis failed but locally it pass the tests. |
|
Build is broken on develop since 698ff9a. It would be good to fix that so all PR could properly run tests. |
|
Ok then. Let me check my local changes to see if I did already fix it. |
introduce header/footer for no-js ui
introduce header/footer for no-js ui
and link each search result to /metadata/{uuid} (urlrewrite can forward this to some formatter for the metadata)
The development indicates a way the layout of angular app can be reused partially (it includes the css from angular app) on the no-js interface. Idea behind improving the no-js interface is triggered from search engine crawlability, but off course no-js users/browsers will also profit