-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Python API in the JupyterLite deployment #412
Conversation
Integration tests report: appsharing.space |
Is this change enabled by an enhancement to JupyterLite? Could you please add some context links? 🙇 |
David is looking into making the Python API work in JupyterLite 🚀 Making good progress this week! You can give it a try here https://davidbrochart.github.io/jupytergis-demo (note not everything is working yet) It is built from https://github.com/davidbrochart/jupytergis-demo Once we have something stable, we should update our JupyterLite deployment with what David has there. Probably as part of this PR here? |
Yes, there are other changes that will make |
742b70e
to
b303f02
Compare
747616f
to
34006b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! I have some suggestions
Thanks @martinRenou. |
Oh I see:
|
Now the error is:
|
7dc7400
to
16614e5
Compare
Rebased from the UI |
16614e5
to
8181441
Compare
I just pushed two new commits (+ the linter one)
This works only with QuantStack/yjs-widgets#22 Case 1: Open an existing file (path is relative to the current context aka Notebook)Uploading Screencast From 2025-02-06 18-25-05.mp4… Upload doesn't work, but hey it's working Case 2: Open a non-existing file, we create it (path is relative to the current context aka Notebook)Screencast.From.2025-02-06.18-21-38.mp4Case 3: Open without passing a file path, we don't create anythingScreencast.From.2025-02-06.18-24-32.mp4 |
Co-authored-by: martinRenou <martin.renou@gmail.com>
8181441
to
7dd2bf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're hitting flaky visual regression test, let's go ahead with this!!
Thanks David
import { | ||
IJupyterYWidget, | ||
IJupyterYWidgetManager, | ||
JupyterYDoc, | ||
// JupyterYDoc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// JupyterYDoc, |
Awesome to see! Thanks for this great work. |
Description
Fix #369
Fix #342
Checklist
Resolves #XXX
.Failing lint checks can be resolved with:
pre-commit run --all-files
jlpm run lint
📚 Documentation preview: https://jupytergis--412.org.readthedocs.build/en/412/
💡 JupyterLite preview: https://jupytergis--412.org.readthedocs.build/en/412/lite