Openblas0.2.20 #800

kiwifb · 2017-07-25T02:08:51Z

Move the latest openblas available to the newly released 0.2.20. This new release includes all the patches that were applied to 0.2.19 - including the big clang-3.9 patch stored on the mirror.
This new version also supports more (and newer) cpus out of the box, which has been a problem I have seen crop up on a regular basis on other forum.

kiwifb · 2017-07-25T02:11:39Z

I limited the PR to move to 0.2.20. Is there any real valid reasons for us to continue carrying the older 0.2.14 and 0.2.15? Especially considering they require significant patching and won't support newer cpus?

kiwifb · 2017-08-14T22:33:30Z

In case that's what holding this up, I have updated my GPG key to reflect my new address. So now the commits are all "verified".

kiwifb · 2017-08-21T00:06:45Z

One commit has been included in the final push to release 0.2.20 that prevents openblas to build on platform not using glibc (OS X for example). See OpenMathLib/OpenBLAS#1258 (comment)

I will update the PR with upstream fix for the problem. It will be included in the next release, which for some reason, is slow coming.

kiwifb · 2017-08-21T02:42:31Z

Travis is not happy because of the new repoman which checks for https in SRC_URI. I have fixed it for openblas (all versions) in this PR but I haven't touched the other ebuilds for which it fails.

heroxbd

Thanks a lot for the bump, especially for solving the header issue. Could you please rebase your branch to the current head, get rid of the merge commit and squash the https SRC_URI commit with the other SRC_URI one?

heroxbd · 2017-08-23T01:31:34Z

sci-libs/openblas/openblas-0.2.14.ebuild

 		# avoid pic when compiling static libraries, so re-compiling
 		if use static-libs; then
 			emake clean
 			emake libs ${openblas_flags} NO_SHARED=1 NEED_PIC=
-			mv libopenblas* libs/ || die
+			mv libopenblas* libs/ ||??die
 		fi


François, your editor has messed up die again.

You are right. This is quite incredible, is that space some kind of unicode?

What editor are you using? I will try to avoid it in the future ;)

I use a mix of kwrite and nano. My money is on kwrite doing something weird, but that implies that there is something special about that space - or its surroundings - to start with.

heroxbd · 2017-08-23T01:33:37Z

sci-libs/openblas/openblas-0.2.20.ebuild

@@ -21,8 +21,6 @@ DEPEND="${RDEPEND}
 	virtual/pkgconfig"

 MULTILIB_WRAPPED_HEADERS=(
-	/usr/include/openblas/cblas.h
-	/usr/include/openblas/f77blas.h
 	/usr/include/openblas/openblas_config.h


Thanks, that's cleaner! Could you please add a reference in the commit message to the solution of header problem in bugs.g.o?

heroxbd · 2017-08-23T01:35:31Z

sci-libs/openblas/files/openblas-0.2.19-MAKE.patch

-	make -j 1 -C $(NETLIB_LAPACK_DIR) blas_testing
-+	$(MAKE) -j 1 -C $(NETLIB_LAPACK_DIR) blas_testing
- 	(cd $(NETLIB_LAPACK_DIR)/BLAS && cat *.out)
-


So.. this patch is for openblas-0.20, but the name openblas-0.2.19-MAKE.patch. Does it break the openblas-0.19 ebuild?

You are misreading the commit. I remove the whole patch. In fact I remove 0.2.19 and replace it with 0.2.20.

Yes, I realized that you have deleted openblas-0.2.19. Could you please keep the openblas-0.2.19 for a while?

Sure. I will probably restart the branch from scratch.

Thanks again for your work!

heroxbd · 2017-08-23T01:36:17Z

virtual/blas/blas-2.1-r5.ebuild

@@ -24,7 +24,7 @@ RDEPEND="
 		abi_x86_64? (
 			!abi_x86_32? (
 				|| (
-					>=dev-cpp/eigen-3.1.4
+					>=dev-cpp/eigen-3.1.4[fortran]
 					sci-libs/atlas[fortran]


Is this from a different PR?

kiwifb · 2017-08-23T01:46:21Z

@heroxbd The header issue requires #802 to be merged first. Are you on top of that?

Package-Manager: Portage-2.3.8, Repoman-2.3.3

Package-Manager: Portage-2.3.6, Repoman-2.3.3

kiwifb · 2017-08-23T01:53:32Z

@heroxbd Are you going to do a sweep of the overlay to fix the https issue? If you do that, I'll wait for it to be done before recreating the branch.

heroxbd · 2017-08-23T01:57:57Z

The header issue requires #802 to be merged first. Are you on top of that?

I am digesting it and learning from you.

Are you going to do a sweep of the overlay to fix the https issue? If you do that, I'll wait for it to be done before recreating the branch.

Why is it important? Does 301 redirection a big problem?

kiwifb · 2017-08-23T02:00:16Z

the https things makes travis check fail for everyone. That's what I am concerned about. You cannot rely on travis as an extra check.

kiwifb · 2017-08-23T02:22:03Z

Actually once #802 is merged (one way or another). I should fix all the openblas ebuilds in the overlay. Which means they will all get a revbump.

heroxbd · 2017-08-23T03:24:48Z

Actually once #802 is merged (one way or another). I should fix all the openblas ebuilds in the overlay. Which means they will all get a revbump.

Sure. Please go ahead.

Please follow the guide at https://github.com/gentoo/sci/blob/master/CONTRIBUTING.md to properly rebase the commits.

…pper issue. Use https to make repoman happy. Package-Manager: Portage-2.3.6, Repoman-2.3.3

kiwifb · 2017-08-23T05:15:58Z

Hum... I have redone the branch on the current master (minus #802 I had started before you merged it) but it still remembers the point at which I started the PR. Should I just do a new PR or will it do?

jlec approved these changes Jul 25, 2017

View reviewed changes

jlec assigned SoapGentoo Jul 25, 2017

heroxbd requested changes Aug 23, 2017

View reviewed changes

TheChymera added 3 commits August 23, 2017 10:49

sci-libs/nibabel: fixed indentation

6c402b0

Package-Manager: Portage-2.3.8, Repoman-2.3.3

sci-libs/nipy: version bump

a8b5398

Package-Manager: Portage-2.3.6, Repoman-2.3.3

sci-libs/nipype: added dependencies

dd97f69

Package-Manager: Portage-2.3.6, Repoman-2.3.3

sci-libs/openblas: Bump to 0.2.20. Clean up after fixing multilib wra…

fc9997f

…pper issue. Use https to make repoman happy. Package-Manager: Portage-2.3.6, Repoman-2.3.3

kiwifb force-pushed the openblas0.2.20 branch from 58ed977 to fc9997f Compare August 23, 2017 05:11

heroxbd mentioned this pull request Aug 23, 2017

sci-libs/openblas: Version Bump to 0.2.18 #632

Closed

gentoo-bot closed this in 5b06cf9 Aug 25, 2017

kiwifb deleted the openblas0.2.20 branch October 16, 2018 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Openblas0.2.20 #800

Openblas0.2.20 #800

kiwifb commented Jul 25, 2017

kiwifb commented Jul 25, 2017

kiwifb commented Aug 14, 2017

kiwifb commented Aug 21, 2017

kiwifb commented Aug 21, 2017

heroxbd left a comment

heroxbd Aug 23, 2017

kiwifb Aug 23, 2017

heroxbd Aug 23, 2017

kiwifb Aug 23, 2017

heroxbd Aug 23, 2017

heroxbd Aug 23, 2017

kiwifb Aug 23, 2017

heroxbd Aug 23, 2017

kiwifb Aug 23, 2017

heroxbd Aug 23, 2017

heroxbd Aug 23, 2017

kiwifb commented Aug 23, 2017

kiwifb commented Aug 23, 2017

heroxbd commented Aug 23, 2017

kiwifb commented Aug 23, 2017

kiwifb commented Aug 23, 2017

heroxbd commented Aug 23, 2017 •

edited

Loading

kiwifb commented Aug 23, 2017

Openblas0.2.20 #800

Openblas0.2.20 #800

Conversation

kiwifb commented Jul 25, 2017

kiwifb commented Jul 25, 2017

kiwifb commented Aug 14, 2017

kiwifb commented Aug 21, 2017

kiwifb commented Aug 21, 2017

heroxbd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kiwifb commented Aug 23, 2017

kiwifb commented Aug 23, 2017

heroxbd commented Aug 23, 2017

kiwifb commented Aug 23, 2017

kiwifb commented Aug 23, 2017

heroxbd commented Aug 23, 2017 • edited Loading

kiwifb commented Aug 23, 2017

heroxbd commented Aug 23, 2017 •

edited

Loading