Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADA runtime update for GCC 12 #4880

Closed
chelmuth opened this issue May 15, 2023 · 2 comments
Closed

ADA runtime update for GCC 12 #4880

chelmuth opened this issue May 15, 2023 · 2 comments
Assignees
@cnuke
Labels
feature fixed

Comments

@chelmuth
Copy link
Member

The build of lib.spark and the test-spark" components fails with GCC 12. Issue #4827 states an update of the ADA runtime in repos/libports/ports/ada-runtime.port is required.
@cnuke cnuke self-assigned this May 15, 2023
cnuke added a commit to cnuke/genode that referenced this issue May 16, 2023
@cnuke
ada: ignore unknown pragmas
a78339d 
Triggered by the toolchain update to GCC 12 certain pragmas lead to
a build error as those are now unknown. As quick-fix add '-gnatwG',
which suppresses warnings on unrecognized pragmas.

Issue genodelabs#4880.
cnuke added a commit to cnuke/genode that referenced this issue May 16, 2023
@cnuke
libports: update ada-runtime .ali files for GCC 12
bf0d1ef 
Issue genodelabs#4880.
@cnuke
Copy link
Member

cnuke commented May 16, 2023 •
edited
Loading

Commit a78339d address the compiler warning turned into an error and commit be10394 update the .ali files. With that changes test-spark, test-spark_exception and test-spark_secondary_stack (via depot_autopilot.run) work again.

I did not update the runtime itself, it is still the original version imported from GCC 8.3 and I am hesitant to do that if it is not really required. I noticed the discussion in Componolit/ada-runtime/issues/86 and judging by a brief looking at the current GNAT sources updating would indeed involve some integration work.

EDIT: include port hash update.

cnuke added a commit to cnuke/genode that referenced this issue May 16, 2023
@cnuke
libports: update ada-runtime .ali files for GCC 12
be10394 
Issue genodelabs#4880.
chelmuth pushed a commit that referenced this issue May 16, 2023
@cnuke @chelmuth
ada: ignore unknown pragmas
dd657b0 
Triggered by the toolchain update to GCC 12 certain pragmas lead to
a build error as those are now unknown. As quick-fix add '-gnatwG',
which suppresses warnings on unrecognized pragmas.

Issue #4880.
chelmuth pushed a commit that referenced this issue May 16, 2023
@cnuke @chelmuth
libports: update ada-runtime .ali files for GCC 12
3050c64 
Fixes #4880
@chelmuth
Copy link
Member Author

That's fantastic - I like your pragmatic approach! It works like a charm in the test-spark* scenarios.

@chelmuth chelmuth added the fixed label May 16, 2023
chelmuth pushed a commit that referenced this issue May 30, 2023
@cnuke @chelmuth
ada: ignore unknown pragmas
6355b48 
Triggered by the toolchain update to GCC 12 certain pragmas lead to
a build error as those are now unknown. As quick-fix add '-gnatwG',
which suppresses warnings on unrecognized pragmas.

Issue #4880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnuke cnuke

Labels
feature fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chelmuth @cnuke