Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.2.0 #63

Merged
merged 6 commits into from
Jan 30, 2021
Merged

Prepare 0.2.0 #63

merged 6 commits into from
Jan 30, 2021

Conversation

gendx
Copy link
Owner

@gendx gendx commented Dec 12, 2020

Pull Request Overview

This pull request fixes various pending comments from #59 to prepare the release of version 0.2.0.

Testing Strategy

This pull request was tested by Travis-CI

Supporting Documentation and References

N/A

TODO or Help Wanted

For now, streaming decompression fails in some test cases, which is blocking this release. CC @cccs-sadugas.

@gendx gendx mentioned this pull request Dec 12, 2020
2 tasks
@cccs-sadugas
Copy link
Contributor

Thanks for adding more chunk size testing. I'll have a look at the test results today.

@cccs-sadugas
Copy link
Contributor

Only chunks of size of 1 and compressed.len() work. All others do not: 2, 3, 4, 5, 6, 7, 8, 16, 32, 64, 128, 256, 512, 1024.

However, this assertion holds: assert_eq!(&decomp[..], &expected[..decomp.len()]). There is an additional 599 bytes of all zeros in the expected value for all of the failing chunk sizes. More debugging to follow.

@cccs-sadugas
Copy link
Contributor

Finally found the bug. The partial_input_buf was not being accounted for in the eof checks. PR is coming shortly with a fuzzing target that helped a lot to find a smaller failing input. Sorry for the late response as I was busy releasing other open source projects.

@gendx gendx merged commit 8925ec8 into master Jan 30, 2021
@gendx gendx deleted the prepare-0.2.0 branch January 30, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants