-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some major LZMA2 decompression issues #61
Conversation
Thanks for taking a look at this!
I merged #59 this week, which refactored quite a bit of code. But even if your bug ended up being fixed in the meantime, adding more test cases is always welcome! |
That was the contrary, my bug hadn't been fixed in the meantime and I was not able to fix it on master. The good news is that I succeeded today, and three more test cases from the XZ test suite pass now with master + my own fixes. |
This overall looks good. Just a couple comments regarding the failing Travis-CI:
|
Okay, I've reformatted the code according to cargo's rules. |
Pull Request Overview
This pull request fixes several issues with the LZMA2 decompression.
Testing Strategy
This pull request was tested by myself. It allows to decompress several files whose decompression failed before. This is the case of the good-1-lzma2-4.xz file from the XZ test suite, so I added it in the test directory. The last two fixes are required to decompress it.
.lzma
,.lzma2
,.xz
files).Note that this PR seems to improve the decompression of some other tests from the XZ test suite: decompression fails because of CRC errors instead of invalid status errors.
TODO or Help Wanted
This pull request is based on the v0.1.3 version and still needs to be rebased on top of master. Lots of changes occurred since the v0.1.3 version and for some reason I'm not able to reproduce my results with master so far. I'm afraid a regression might have been introduced at some point. I'll try again but any help would be welcome.