lzbuffer: own output sink instead of holding ref #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Changes
LZBuffer
trait to consume the output sink instead of holding areference to it. This makes it easier to store the sink and avoids
self-referential structs. It also makes sense for the buffer to own the
sink while it is performing decompression.
This also adds the methods
get_output
andget_output_mut
to accessthe output sink.
This pull request is needed by future versions of PR #51.
Testing Strategy
This pull request was tested by...
.lzma
,.lzma2
,.xz
files).Should already be covered by existing tests.
Supporting Documentation and References
Benchmarks:
master
owned_output_sink