fix: correctly close half-opened socket #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
approved these changes
Jul 31, 2019
lib/http-proxy/passes/ws-incoming.js
Outdated
| @@ -131,10 +131,13 @@ module.exports = { | |||
| // The pipe below will end proxySocket if socket closes cleanly, but not | |||
| // if it errors (eg, vanishes from the net and starts returning | |||
| // EHOSTUNREACH). We need to do that explicitly. | |||
| socket.on('error', function () { | |||
| socket.on('error', function (err) { | |||
| console.warn('WARN: socket closed with error:', err); | |||
lib/http-proxy/ws/interceptor.js
Outdated
| @@ -50,10 +50,12 @@ module.exports = class Interceptor { | |||
| this._serverExtensions = this._isCompressed ? acceptExtensions({extensions, isServer: true}) : null; | |||
| } | |||
|
|
|||
| _getDataSender({sender, event, options}) { | |||
| _getDataSender({sender, type, event, options}) { | |||
There was a problem hiding this comment.
давай тип будем сразу в sender-е хранить
518a718 to
1ba7b77
Compare
1ba7b77 to
b1247c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.