Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users/mordvinx/testplane 404.new UI error boundaries #630

Merged
merged 36 commits into from
Jan 24, 2025
Merged

Users/mordvinx/testplane 404.new UI error boundaries #630

merged 36 commits into from
Jan 24, 2025

Conversation

mordvinx
Copy link
Contributor

@mordvinx mordvinx commented Jan 20, 2025 •
edited
Loading

Added ErrorHandler components, which prevents app from crashing to white screen.

A small passing refactor was executed.

= added 12 commits January 16, 2025 13:16
feat(css): add min-width and min-height to app
eee0828 
In the future, it will help to render ErrorBoundary to the full screen.
refactor(visual-checks): extract VisualCheckStickyHeader FC
86c22e4
refactor(test-steps): raise CollapsibleSection, extract TestStep FC
cf910c8
feat(error-handling): add ErrorHandling components
cce2f47
style(suite-title): remove unused interface
f69b768
feat(test-step): add corrupted style for test step item
d7855ab
feat(error-handling): add usages of ErrorHandler component
908c74d
refactor(error-handler): rename file
d0e8138
refactor(error-handler): reorganize components
13656c3
feat(error-handler): add top level error handler
c62ee5e
feat(error-handler): additional message
803eb62
fix(icons): add new icons
ded253f 
Не добавил сразу, потому что они под gitignore
shadowusr
shadowusr requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@shadowusr shadowusr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отличный шаг в сторону более стабильного UX! Круто, что покрыто столько кейсов, мне понравилось! 🔥

Есть ряд вопросов насчет расхождений с макетами, предлагаю обсудить в комментах.

shadowusr
shadowusr reviewed Jan 21, 2025
View reviewed changes
@mordvinx
Copy link
Contributor Author

@shadowusr можно смотреть

shadowusr
shadowusr approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом критичных замечаний нет, написал несколько моментов по дизайну и хотелось бы разобраться зачем нужны watchFor+restore

@mordvinx
Copy link
Contributor Author

@shadowusr можно отсматривать, оставшиеся комменты жду от тебя резолв либо дополнения

shadowusr
shadowusr approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@shadowusr shadowusr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Помимо опечаток больше замечаний нет

@mordvinx mordvinx merged commit f92dee5 into gemini-testing:master Jan 24, 2025
4 checks passed
@mordvinx mordvinx deleted the users/mordvinx/TESTPLANE-404.new-ui-error-boundaries branch January 24, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadowusr shadowusr shadowusr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mordvinx @shadowusr