-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not lose meta.url if it is specified and apply base host to all urls in meta #583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
@@ -95,8 +95,19 @@ class MetaInfoContent extends Component { | |||
formattedMetaInfo[key] = {content: formattedMetaInfo[key]}; | |||
}); | |||
|
|||
if (result.suiteUrl) { | |||
formattedMetaInfo.url = {content: result.metaInfo.url || result.suiteUrl, url: getUrlWithBase(result.suiteUrl, baseHost)}; | |||
for (const [key, value] of Object.entries(formattedMetaInfo)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm not sure that we should replace base host for all urls in meta. I believe that by default it should only be used for url
field and other fields should be specified by user through metaInfoBaseUrls
option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we apply baseHost only if metaInfoBaseUrls was set to 'auto'.
4ef266d
to
67c7e51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
67c7e51
to
346fdbc
Compare
What's done: