Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins): add menu-bar extension point #383

Merged
merged 1 commit into from
Jun 11, 2021
Merged

feat(plugins): add menu-bar extension point #383

merged 1 commit into from
Jun 11, 2021

Conversation

Aracturat
Copy link
Contributor

Add new extension point to extend menu bar (other way is extraItems property).

DudaGod
DudaGod reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add tests for menu-bar component and I will merge it.

@Aracturat Aracturat force-pushed the FEI-20423.add_menu-bar_extension_point branch from ba76502 to 8489576 Compare June 9, 2021 08:26
@Aracturat
Copy link
Contributor Author

@DudaGod Added tests, please review and merge

@Aracturat Aracturat force-pushed the FEI-20423.add_menu-bar_extension_point branch 4 times, most recently from 3d93433 to 4a3bfba Compare June 10, 2021 10:53
@Aracturat
Copy link
Contributor Author

@DudaGod Added tests, please review and merge

@Aracturat Aracturat force-pushed the FEI-20423.add_menu-bar_extension_point branch from 4a3bfba to c180c8e Compare June 11, 2021 10:00
@DudaGod DudaGod merged commit 6115ada into gemini-testing:master Jun 11, 2021
@Aracturat Aracturat deleted the FEI-20423.add_menu-bar_extension_point branch June 11, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DudaGod DudaGod DudaGod left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aracturat @DudaGod