This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
fix: pass current image path to reference image error #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Aug 31, 2017
|
|
||
| const throwNoRefError = (referencePath) => Promise.reject(new NoRefImageError(referencePath)); | ||
| const throwNoRefError = (referencePath, capture) => { |
There was a problem hiding this comment.
Данный обработчик зовется тут - https://github.com/gemini-testing/gemini/blob/master/lib/state-processor/capture-processor/capture-processor.js#L40
В него всегда летел capture, но как мне казалось он мне был не нужен. Ошибся )
|
/ok |
j0tunn
reviewed
Aug 31, 2017
| }); | ||
|
|
||
| it('should pass reference and current image paths to "NoRefImageError"', () => { | ||
| sandbox.stub(NoRefImageError.prototype, '__constructor'); |
There was a problem hiding this comment.
вот это не будет работать когда ты вольешь PR про ошибки. __constructor - это же кишки inherit
There was a problem hiding this comment.
просто поймай ошибку, и посмотри, что в ней есть currentPath
548efb3 to
3b3a87b
Compare
This was referenced Feb 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.