Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish/bump scripts #414

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add publish/bump scripts #414

merged 1 commit into from
Mar 18, 2025

Conversation

mmastrac
Copy link
Contributor

New version bump and publish scripts.

The workflow is pretty simple:

just publish

... will run the publication process, comparing each crate against the latest published version.

Nothing stops us from running the older-style publication process and both of them can coexist. I suspect there might be a weird corner case where the test cargo publish is unable to generate a package because there's a missing upstream dependency, but I wasn't able to reproduce it.

This worked to republish all of the crates in two smaller batches, but I'll keep refining it as we go.

@mmastrac mmastrac requested review from elprans and aljazerzen March 18, 2025 01:46
@aljazerzen
Copy link
Contributor

What's the problem that these scripts solve? Easier publication compared to tagging and pushing to gh?

It is an improvement in that regard.

I am a bit skeptical about it being written in bash, otherwise looks good.

@mmastrac
Copy link
Contributor Author

mmastrac commented Mar 18, 2025

The current process is error-prone, it's non-trivial to publish n > 1 packages and it is very difficult to know when packages are actually out of date. I've been burned by this a few times lately.

As we break up and publish more and more crates, this is only going to get more and more painful without tooling.

I am not usually a fan of bash for complex scripts, but this is pretty simple and is mostly coordination of other processes. I believe the majority (or close to) of the lines are just "echo".

@mmastrac mmastrac merged commit 7ee78a1 into geldata:master Mar 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants