Fix examples #87
Closed
Fix examples #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be0d4d0 to
7d7e5ec
Compare
9 tasks
|
Try adding the examples/init.py file back in. That tells python that the directory is a module and I think its needed for pytest to run the examples unit test. |
|
Well that didn't work. Let me have a poke at this... |
|
It's a strange thing, to be honest. Theoretically, it should just be removable and the only change should be that it doesn't get installed in the end. But because of bugs like pypa/setuptools#2688 I'm not sure what the best approach is. |
|
I believe I've fixed this problem in master. |
|
Thank you! Would you mind creating a new release for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, examples is installed as a separate package as it doesn't live under the src dir. This PR should exclude it.
Note: This is guesswork though because I'm not sure why it's even included in the first place.
Closes #88