Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ethexe): add getters for *.sol contract interfaces on Rust side #4441

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Jan 14, 2025

@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Jan 14, 2025
@playX18 playX18 requested a review from breathx January 14, 2025 07:23
@playX18 playX18 self-assigned this Jan 14, 2025
@playX18 playX18 changed the title chore(ethexe): add getters for SOL contract interfaces on Rust side chore(ethexe): add getters for *.sol contract interfaces on Rust side Jan 14, 2025
.map_err(Into::into)
}

pub async fn validate_codes_count(&self) -> Result<U256> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub async fn validate_codes_count(&self) -> Result<U256> {
pub async fn validated_codes_count(&self) -> Result<U256> {

.map_err(Into::into)
}

pub async fn program_code_ids(&self, program_ids: Vec<ProgramId>) -> Result<Vec<CodeId>> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub async fn program_code_ids(&self, program_ids: Vec<ProgramId>) -> Result<Vec<CodeId>> {
pub async fn programs_code_ids(&self, program_ids: Vec<ProgramId>) -> Result<Vec<CodeId>> {

@@ -267,4 +271,76 @@ impl RouterQuery {
let code_id = Some(CodeId::new(code_id._0.0)).filter(|&code_id| code_id != CodeId::zero());
Ok(code_id)
}

pub async fn signing_threshold_percentage(&self) -> Result<u16> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to sort them for better navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants