-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to gdsfactory9 #65
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request migrates the gvtt project to gdsfactory9, updates dependencies, improves code clarity with type hints, refactors component port definitions, and updates test files to reflect changes in cross-section naming and routing information. Updated class diagram for bend_euler componentclassDiagram
class bend_euler {
angle: float
p: float
with_arc_floorplan: bool
npoints: Optional[int]
direction: str
with_bbox: bool
cross_section: CrossSectionSpec
+bend_euler()
}
note for bend_euler "radius is no longer None"
Updated class diagram for mmi1x2 componentclassDiagram
class mmi1x2 {
length_taper: float
length_mmi: float
width_mmi: float
gap_mmi: float
taper: ComponentSpec
straight: ComponentSpec
cross_section: CrossSectionSpec
+mmi1x2()
}
note for mmi1x2 "ports are now added using temp_component"
Updated class diagram for mmi2x2 componentclassDiagram
class mmi2x2 {
length_taper: float
length_mmi: float
width_mmi: float
gap_mmi: float
taper: ComponentSpec
straight: ComponentSpec
cross_section: CrossSectionSpec
+mmi2x2()
}
note for mmi2x2 "ports are now added using temp_component"
Updated class diagram for transitions componentsclassDiagram
class xs_rib_strip {
width_deep: float
dist_deep: float
wg_marking_layer: LayerSpec | None
+xs_rib_strip()
}
class rib_to_strip {
length: float
width1: float
width2: float
+rib_to_strip()
}
class strip_to_rib {
length: float
width1: float
width2: float
+strip_to_rib()
}
class strip_taper {
width1: float
width2: float
taper_ratio: float
length: float | None
+strip_taper()
}
class rib_taper {
width1: float
width2: float
taper_ratio: float
length: float | None
+rib_taper()
}
Updated class diagram for tech componentsclassDiagram
class rib {
width: float
width_trench: float
wg_marking_layer: LayerSpec
+rib()
}
class strip {
width: float
width_trench: float
wg_marking_layer: LayerSpec
+strip()
}
class vttstrip {
width: float
width_trench: float
wg_marking_layer: LayerSpec | None
+vttstrip()
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Summary by Sourcery
Migrate the project to gdsfactory9, update the build system to use uv, and improve type hints and code organization.
Enhancements:
temp_component.add_port
for port definitions, enhancing code organization.Build:
pip
touv
for package management, improving installation speed and dependency resolution.Tests:
Chores:
pyproject.toml
.