fix layer naming in LayerInfos

[sebastian-goeldi]

Summary by Sourcery

Bug Fixes:

• Fixed a bug where layers in LayerInfos were not being named correctly.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes the layer naming validation logic in the _validate_layers method. Instead of using the f.is_named() method to check if a layer is named, the code now directly checks the f.name attribute, ensuring that unnamed layers are correctly assigned a name based on their field identifier.

Flow diagram for updated layer naming validation

flowchart TD
    A[Start _validate_layers method]
    B{Is f.name set?}
    C[Set f.name = field_name]
    D[Check if f.layer == -1 or f.datatype == -1]
    E[Raise InvalidLayerError]
    F[Layer validation successful]

    A --> B
    B -- No --> C
    B -- Yes --> D
    C --> D
    D -- Error Condition Met --> E
    D -- Otherwise --> F

Loading

File-Level Changes

Change	Details	Files
Updated layer naming condition	Replaced the condition using f.is_named() with a direct check on f.name Ensured that when a layer name is not set, it is assigned the field name	src/kfactory/layer.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.89%. Comparing base (b9f220a) to head (26911f0).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   65.91%   65.89%   -0.02%     
==========================================
  Files          64       64              
  Lines        9695     9695              
  Branches     1805     1805              
==========================================
- Hits         6390     6389       -1     
  Misses       2780     2780              
- Partials      525      526       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.