-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix electrical route bundle #605
Conversation
Reviewer's Guide by SourceryThis pull request refactors the route_bundle function in the electrical routing module by adding overloads for DKCell and DPort types, expanding parameter support, and adjusting type conversions. Additionally, the optical routing module has been updated to use unit conversions based on micrometers (um) instead of dbu in the straight factory function. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 65.94% 65.77% -0.17%
==========================================
Files 64 64
Lines 9656 9693 +37
Branches 1787 1802 +15
==========================================
+ Hits 6368 6376 +8
- Misses 2762 2793 +31
+ Partials 526 524 -2 ☔ View full report in Codecov by Sentry. |
Fix the um-based routings. Needed for gdsfactory/gdsfactory#3653