Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mirror default parameters #600

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Fix mirror default parameters #600

merged 1 commit into from
Feb 8, 2025

Conversation

MatthewMckee4
Copy link
Member

@MatthewMckee4 MatthewMckee4 commented Feb 8, 2025

Summary by Sourcery

Bug Fixes:

  • Fixed the default parameters of the mirror function.

Copy link
Contributor

sourcery-ai bot commented Feb 8, 2025

Reviewer's Guide by Sourcery

This pull request corrects the default mirror parameters in the geometry module by updating the default values of the p1 argument for both integer and float mirror functions. The changes ensure that the mirror functions now use the appropriate default values.

Updated class diagram for Geometry mirror functions

classDiagram
    class Geometry {
      +imirror(p1: tuple[int,int] = (0, 1000), p2: tuple[int,int] = (0, 0))
      +dmirror(p1: tuple[float,float] = (0, 1), p2: tuple[float,float] = (0, 0))
      +mirror(int): Self <<calls imirror>>
      +mirror(float): Self <<calls dmirror>>
    }
    note for Geometry "Default mirror parameters updated from (1000, 0)/(1, 0) to (0, 1000)/(0, 1)"
Loading

File-Level Changes

Change Details Files
Corrected default parameters in integer mirror functions.
  • Updated the default value of p1 for the imirror function from (1000, 0) to (0, 1000).
  • Updated the default value of p1 for the integer alias mirror function from (1000, 0) to (0, 1000).
src/kfactory/geometry.py
Corrected default parameters in float mirror functions.
  • Updated the default value of p1 for the dmirror function from (1, 0) to (0, 1).
  • Updated the default value of p1 for the float alias mirror function from (1, 0) to (0, 1).
src/kfactory/geometry.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@github-actions github-actions bot added the bug Something isn't working label Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.88%. Comparing base (0a8cde9) to head (5de4094).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   65.87%   65.88%   +0.01%     
==========================================
  Files          64       64              
  Lines        9644     9644              
  Branches     1786     1786              
==========================================
+ Hits         6353     6354       +1     
  Misses       2767     2767              
+ Partials      524      523       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastian-goeldi sebastian-goeldi merged commit 2d09f09 into main Feb 8, 2025
18 checks passed
@sebastian-goeldi sebastian-goeldi deleted the fix-mirror branch February 8, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants