-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mirror default parameters #600
Conversation
Reviewer's Guide by SourceryThis pull request corrects the default mirror parameters in the geometry module by updating the default values of the p1 argument for both integer and float mirror functions. The changes ensure that the mirror functions now use the appropriate default values. Updated class diagram for Geometry mirror functionsclassDiagram
class Geometry {
+imirror(p1: tuple[int,int] = (0, 1000), p2: tuple[int,int] = (0, 0))
+dmirror(p1: tuple[float,float] = (0, 1), p2: tuple[float,float] = (0, 0))
+mirror(int): Self <<calls imirror>>
+mirror(float): Self <<calls dmirror>>
}
note for Geometry "Default mirror parameters updated from (1000, 0)/(1, 0) to (0, 1000)/(0, 1)"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
+ Coverage 65.87% 65.88% +0.01%
==========================================
Files 64 64
Lines 9644 9644
Branches 1786 1786
==========================================
+ Hits 6353 6354 +1
Misses 2767 2767
+ Partials 524 523 -1 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Bug Fixes:
mirror
function.