-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dagster plugin #550
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Lumerical Interconnect integration, enhancing simulation control and component layout. It also removes the Dagster plugin. Updated class diagram for Interconnect integrationclassDiagram
class add_interconnect_element {
+session: Interconnect session
+label: str
+model: str
+loc: tuple
+flip_vert: bool
+flip_horiz: bool
+rotation: float
+simulation_props: dict
}
class send_to_interconnect {
+component: Component
+session: Interconnect session
+ports_in: dict
+ports_out: dict
+placements: list
+simulation_settings: dict
+drop_port_prefix: str
+component_distance_scaling_x: float
+component_distance_scaling_y: float
+setup_mc: bool
+exclude_electrical: bool
+settings: dict
}
class run_wavelength_sweep {
+component: Component
+session: Interconnect session
+setup_simulation: bool
+is_top_level: bool
+ports_in: dict
+ports_out: dict
+mode: str
+wavelength_range: tuple
+n_points: int
+results: list
+extra_ona_props: dict
+kwargs: dict
}
note for add_interconnect_element "Updated simulation_props"
note for send_to_interconnect "Added component_distance_scaling_x, component_distance_scaling_y, setup_mc, exclude_electrical, settings"
note for run_wavelength_sweep "Added is_top_level and mode"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Label error. Requires at least 1 of: breaking, bug, github_actions, documentation, dependencies, enhancement, feature, maintenance, security. Found: |
Summary by Sourcery
This pull request removes the Dagster plugin and improves documentation for Lumerical Interconnect functions.
Enhancements:
add_interconnect_element
andrun_wavelength_sweep
functions by clarifying argument descriptions.Chores: