Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDSFactory 9 #549

Merged
merged 40 commits into from
Feb 20, 2025
Merged

GDSFactory 9 #549

merged 40 commits into from
Feb 20, 2025

Conversation

MatthewMckee4
Copy link
Member

@MatthewMckee4 MatthewMckee4 commented Feb 19, 2025

Summary by Sourcery

Updates the gdsfactory dependency to version 9.0.0 and enforces Python 3.11 as the minimum supported version. Additionally, the pyproject.toml file was refactored to improve readability and maintainability.

Enhancements:

  • Updates the gdsfactory dependency to version 9.0.0.
  • Enforces Python 3.11 as the minimum supported version.

Chores:

  • Refactors the pyproject.toml file to improve readability and maintainability by removing unnecessary line breaks and standardizing the formatting of dependencies and optional dependencies.

Copy link
Contributor

sourcery-ai bot commented Feb 19, 2025

Reviewer's Guide by Sourcery

This pull request updates the gdsfactory dependency to version 9.0.0, sets the minimum required Python version to 3.11, and refactors the pyproject.toml file for improved readability and maintainability. It also moves file-specific ruff ignores to the correct section.

Updated class diagram for pyproject.toml dependencies

classDiagram
    class pyproject.toml {
        -gdsfactory: str = ">=9.0.0"
        -python: str = ">=3.11"
    }
    note for pyproject.toml "gdsfactory dependency updated to 9.0.0 and minimum python version set to 3.11"
Loading

File-Level Changes

Change Details Files
Updated the gdsfactory dependency to version 9.0.0 and set the minimum required Python version to 3.11.
  • Updated gdsfactory dependency to >=9.0.0.
  • Set requires-python to >=3.11.
pyproject.toml
Consolidated and reformatted the optional dependencies in pyproject.toml for better readability and maintainability.
  • Removed empty lines between optional dependency groups.
  • Reformatted the optional dependency lists to be more compact.
pyproject.toml
Moved file-specific ruff ignores from the lint.per-file-ignores section to the tool.ruff.lint.per-file-ignores section.
  • Moved the file-specific ruff ignores to the correct section.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@MatthewMckee4 MatthewMckee4 added the dependencies Pull requests that update a dependency file label Feb 19, 2025
@joamatab
Copy link
Contributor

joamatab commented Feb 19, 2025

How about we keep "gdsfactory>=8.5.3" until we change something here that breaks the code for gdsfactory8?

@MatthewMckee4
Copy link
Member Author

Okay yeah sounds good

@MatthewMckee4
Copy link
Member Author

I think test_estimate_weighted_global_density in klayout is wrong, the output is based on the bbox for the component, which i think preciously was wrong, im not completely sure why though

@joamatab
Copy link
Contributor

yes, this is probably not fixed since we migrated from gdsfactory7

@MatthewMckee4
Copy link
Member Author

Im not sure what the best way to disable certain plugins is

@joamatab joamatab self-requested a review February 20, 2025 18:02
Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thank you Matthew

@joamatab joamatab added the enhancement New feature or request label Feb 20, 2025
@joamatab joamatab merged commit 96e0ddc into main Feb 20, 2025
14 checks passed
@joamatab joamatab deleted the gdsfactory9 branch February 20, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants