-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDSFactory 9 #549
GDSFactory 9 #549
Conversation
Reviewer's Guide by SourceryThis pull request updates the gdsfactory dependency to version 9.0.0, sets the minimum required Python version to 3.11, and refactors the Updated class diagram for pyproject.toml dependenciesclassDiagram
class pyproject.toml {
-gdsfactory: str = ">=9.0.0"
-python: str = ">=3.11"
}
note for pyproject.toml "gdsfactory dependency updated to 9.0.0 and minimum python version set to 3.11"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
How about we keep "gdsfactory>=8.5.3" until we change something here that breaks the code for gdsfactory8? |
Okay yeah sounds good |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into gdsfactory9
for more information, see https://pre-commit.ci
I think test_estimate_weighted_global_density in klayout is wrong, the output is based on the bbox for the component, which i think preciously was wrong, im not completely sure why though |
yes, this is probably not fixed since we migrated from gdsfactory7 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Im not sure what the best way to disable certain plugins is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! thank you Matthew
Summary by Sourcery
Updates the gdsfactory dependency to version 9.0.0 and enforces Python 3.11 as the minimum supported version. Additionally, the pyproject.toml file was refactored to improve readability and maintainability.
Enhancements:
Chores: