Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest gdsfactory #518

Merged
merged 2 commits into from
Dec 21, 2024
Merged

update to latest gdsfactory #518

merged 2 commits into from
Dec 21, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 21, 2024

Summary by Sourcery

Update design rule check (DRC) with new layers and checks for M1, M2, and M3. Document parameters for clad_material, box_material, and substrate_material in get_simulation_grating_coupler. Add padding_layer parameter to get_simulation_grating_coupler. Add port_source_mode parameter to get_simulation.

Documentation:

  • Document parameters for clad_material, box_material, and substrate_material in get_simulation_grating_coupler
  • Add padding_layer parameter to get_simulation_grating_coupler
  • Add port_source_mode parameter to get_simulation

Copy link
Contributor

sourcery-ai bot commented Dec 21, 2024

Reviewer's Guide by Sourcery

Updated dependencies to latest gdsfactory and added support for M2 and M3 layers.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added layer argument to check_width and check_space functions.
  • Added layer parameter to the function signature.
  • Updated the function docstrings to include the new parameter.
  • Added assertions to validate the type and value of the new parameter.
gplugins/klayout/drc/write_drc.py
Added DRC checks for M2 and M3 layers.
  • Added check_width and check_space calls for M2 and M3 layers in write_drc_deck_macro function.
  • Set default width and space values for M2 and M3 layers to 1.0um.
gplugins/klayout/drc/write_drc.py
Clarified docstrings for get_simulation_grating_coupler function parameters.
  • Clarified the descriptions of box_material and substrate_material parameters.
  • Added documentation for the padding_layer parameter.
gplugins/tidy3d/get_simulation_grating_coupler.py
Added port_source_mode parameter to get_simulation function.
  • Added port_source_mode parameter to the function signature.
  • Updated the function docstrings to include the new parameter.
  • Added logic to handle the new parameter and set the source mode accordingly.
gplugins/gmeep/get_simulation.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

Label error. Requires at least 1 of: breaking, bug, github_actions, documentation, dependencies, enhancement, feature, maintenance, security. Found:

@joamatab joamatab merged commit bf9d1b1 into main Dec 21, 2024
9 of 14 checks passed
@joamatab joamatab deleted the update_gdsfactory826 branch December 21, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant