Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow numpy2 #508

Merged
merged 1 commit into from
Dec 7, 2024
Merged

allow numpy2 #508

merged 1 commit into from
Dec 7, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 7, 2024

waiting for this

HelgeGehring/femwell#183

Summary by Sourcery

Bug Fixes:

  • Fix compatibility with numpy by replacing np.Inf with np.inf.

Copy link
Contributor

sourcery-ai bot commented Dec 7, 2024

Reviewer's Guide by Sourcery

The PR updates the numpy infinity constant usage from np.Inf to np.inf to maintain consistency with numpy's preferred lowercase notation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated numpy infinity constant notation
  • Changed np.Inf to np.inf for minimum z-bound
  • Changed np.Inf to np.inf for maximum z-bound
gplugins/gmsh/uz_xsection_mesh.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added the dependencies Pull requests that update a dependency file label Dec 7, 2024
@joamatab joamatab merged commit a884862 into main Dec 7, 2024
7 of 18 checks passed
@joamatab joamatab deleted the update_numpy2 branch December 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant