Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ruff issues #506

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix ruff issues #506

merged 1 commit into from
Dec 7, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Dec 2, 2024

Summary by Sourcery

Bug Fixes:

  • Fix missing parameter documentation for 'fig' in the plot_model function.

Copy link
Contributor

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This PR updates the docstring of the plot_model function in the SAX plotting module by adding documentation for the fig parameter.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added missing parameter documentation in docstring
  • Added documentation for the 'fig' parameter which represents a matplotlib figure
gplugins/sax/plot_model.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the bug Something isn't working label Dec 2, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab merged commit 85faccc into main Dec 7, 2024
6 of 17 checks passed
@joamatab joamatab deleted the fix_ruff branch December 7, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant