Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meep_adjoint_optimization.py. component.copy() to component.dup() #475

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

kdotom
Copy link
Contributor

@kdotom kdotom commented Aug 23, 2024

updating component.copy() to component.dup() to address warning: "UserWarning: copy() is deprecated and will be removed in gdsfactory9. Please use dup() instead."

updating component.copy() to component.dup() to address warning: "UserWarning: copy() is deprecated and will be removed in gdsfactory9. Please use dup() instead."
Copy link
Contributor

sourcery-ai bot commented Aug 23, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@kdotom
Copy link
Contributor Author

kdotom commented Aug 25, 2024

@joamatab Hey, this is a simple one-line change, but I think the full suite of automatic checks fails for a few unrelated tests (with Sourcery AI). If there's anything specific I'd need to do to make the automated review process smoother for changes like these (or if there's actually an issue with the PR), definitely let me know. Thanks!

Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

yes, we need to fix some of the plugins

@joamatab joamatab merged commit 1127dff into gdsfactory:main Aug 26, 2024
4 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants