Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix klayout netlist #442

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Fix klayout netlist #442

merged 7 commits into from
Jul 25, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jul 18, 2024

Trying to fix the net extractor

the tests are still failing,

@sebastian-goeldi
@nikosavola

it would be great if you could help fixing this

Copy link
Contributor

sourcery-ai bot commented Jul 18, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@github-actions github-actions bot added the bug Something isn't working label Jul 18, 2024
@joamatab joamatab added the help wanted Extra attention is needed label Jul 21, 2024
@joamatab joamatab merged commit 573d5c3 into main Jul 25, 2024
10 of 15 checks passed
@joamatab joamatab deleted the fix_klayout_netlist branch July 25, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant