Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip brackets from model name in Calibre SPICE reader #419

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Strip brackets from model name in Calibre SPICE reader #419

merged 1 commit into from
Jun 11, 2024

Conversation

nikosavola
Copy link
Member

@nikosavola nikosavola commented Jun 10, 2024 •
edited
Loading

A bit nicer output from Calibre SPICE netlists

@nikosavola nikosavola requested a review from joamatab June 10, 2024 09:41
@nikosavola nikosavola self-assigned this Jun 10, 2024
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jun 10, 2024

🧙 Sourcery is reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@nikosavola nikosavola added the enhancement New feature or request label Jun 10, 2024
@nikosavola nikosavola enabled auto-merge June 10, 2024 09:42
joamatab
joamatab approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@joamatab joamatab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thank you Niko!

@nikosavola nikosavola merged commit 7540ca1 into main Jun 11, 2024
18 of 19 checks passed
@nikosavola nikosavola deleted the update-calibre-spice-reader branch June 11, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@joamatab joamatab joamatab approved these changes

Assignees

@nikosavola nikosavola

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikosavola @joamatab