Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom IO streams in execute_and_stream_output #385

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

nikosavola
Copy link
Member

Extend functionality in the async utility function to capture stdout and stderr to custom buffers.

@nikosavola nikosavola added enhancement New feature or request python Pull requests that update Python code labels Apr 23, 2024
@nikosavola nikosavola requested a review from joamatab April 23, 2024 10:42
@nikosavola nikosavola self-assigned this Apr 23, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nikosavola - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@nikosavola nikosavola enabled auto-merge April 23, 2024 10:58
@nikosavola nikosavola merged commit 7400a0e into main Apr 23, 2024
17 of 18 checks passed
@nikosavola nikosavola deleted the extend_async_execution_output branch April 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants